fix(dmg): canonicalize path returns from create_icns_file
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amr-crabnebula shouldn't we create the out-dir upfront instead of making this change? what's your opinion? |
|
yeah we should create the |
|
Hmm, it creates the dir before invoking cargo-packager/crates/packager/src/config/mod.rs Lines 1796 to 1801 in 937de61 |
|
@jason-crabnebula sounds good |
amr-crabnebula
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
out-diris provided but does not exist,create_icns_file()returns a relative path (out/dir/icon.icns). Calling thecreate-dmgscript will change the working dir toout-dir. When copying the volume icon, the icon does not exist at the path (out/dir/out/dir/icon.icns).